Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: Fix Upload JAR step in push workflow #31

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Conversation

ahmedyoussefg
Copy link
Owner

@ahmedyoussefg ahmedyoussefg commented Dec 17, 2024

There was an error in upload-jar step in the workflow done every push, we can't use working-directory here.

@ahmedyoussefg ahmedyoussefg self-assigned this Dec 17, 2024
Copy link

Code Coverage Summary

Overall Project 77.39% 🍏

There is no coverage information present for the Files changed

@ahmedayman4a ahmedayman4a self-requested a review December 17, 2024 23:14
Copy link
Collaborator

@ahmedayman4a ahmedayman4a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This exception is thrown when running the jar.
java.lang.RuntimeException: Driver org.postgresql.Driver claims to not accept jdbcUrl, ${DB_URL}
I think this might be because env.properties is not included in the jar

@ahmedyoussefg
Copy link
Owner Author

java.lang.RuntimeException: Driver org.postgresql.Driver claims to not accept jdbcUrl, ${DB_URL}

Try to export the env variables before running the JAR
@ahmedayman4a

@ahmedayman4a
Copy link
Collaborator

Yes setting the enviroment variables work

export DB_URL=jdbc:postgresql://localhost:5432/knowtopia_dev
export DB_USERNAME=postgres
export DB_PASSWORD=password

@ahmedyoussefg ahmedyoussefg merged commit b772eef into devel Dec 18, 2024
1 check passed
@ahmedyoussefg ahmedyoussefg deleted the fix-jar-workflow branch December 18, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants