[KTP-64] Refactor OAuth Workflow - Move OAuth to Frontend #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he token and creates the user.
Elshaarawy-1
requested review from
MohamedTarek26,
ahmedyoussefg and
MoustafaAmer12
Code Coverage Summary
|
ahmedyoussefg
requested changes
Dec 18, 2024
|
Please write some tests to bump up the code coverage |
…iable instead of direct link
…efg/Knowtopia into KTP-64-Oauth-Refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the OAuth implementation by shifting the authentication process from the backend to the frontend. Now, the frontend handles the OAuth flow, retrieves the access token, and sends it to the backend for validation. The backend validates the token, creates or retrieves the user, and generates a new token for the user to continue using the application securely. This improves separation of concerns and aligns with modern OAuth best practices.