-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Videos and Files Storage Component #35
Conversation
…nd video management
Code Coverage Summary
|
… VideoResponseDTO, and File entities
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, Great job! I approve the changes but once the coverage is increased.
private static final List<String> ALLOWED_FILE_TYPES = Arrays.asList("pdf", "doc", "docx", "ppt", "pptx", "png", "jpg", "jpeg", "txt"); | ||
private static final List<String> ALLOWED_VIDEO_TYPES = Arrays.asList("mp4", "avi", "mov"); | ||
private static final long MAX_FILE_SIZE = 10 * 1024 * 1024; // 10MB | ||
private static final long MAX_VIDEO_SIZE = 100 * 1024 * 1024; // 100MB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be a concern in the future, but no problem for now
cloudinary.cloud-name=dfwyg3lbr | ||
cloudinary.api-key=764171541677637 | ||
cloudinary.api-secret=nzfm9vGh-bBCfyKCSQkKwnZ26aE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On release of milestone 2, we should add these to environment variables along with the OAuth2 secret keys
@Test | ||
@WithMockUser(roles = "USER") | ||
void uploadFile_Success() throws Exception { | ||
when(storageService.storeFile(any(FileUploadDTO.class))).thenReturn(fileResponseDTO); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a look on PR #20 when you are free
No description provided.