-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fertiscan] As a dev, I want to prevent updates and deletions of completed inspections #252
Comments
Do you want to prevent ALL users from deleting it?
This is done # A completed inspection cannot be updated
if inspection.is_inspection_verified(
cursor=cursor,
inspection_id=updated_data.inspection_id
):
raise inspection.InspectionUpdateError("The inspection you are trying to update is already verified")
else:
inspection.update_inspection(
cursor=cursor,
inspection_id=updated_data.inspection_id,
verified=updated_data.verified,
inspection_comment=updated_data.inspection_comment
)
# Rest of the Inspection update logi |
Francois-Werbrouck
added a commit
that referenced
this issue
Feb 26, 2025
Francois-Werbrouck
added a commit
that referenced
this issue
Feb 26, 2025
Francois-Werbrouck
added a commit
that referenced
this issue
Feb 26, 2025
Francois-Werbrouck
added a commit
that referenced
this issue
Feb 27, 2025
Francois-Werbrouck
added a commit
that referenced
this issue
Feb 27, 2025
Francois-Werbrouck
added a commit
that referenced
this issue
Feb 27, 2025
Francois-Werbrouck
added a commit
that referenced
this issue
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
A completed inspection should be immutable. Users should not be able to update or delete it. We want to make sure of this.
In the future, when access policies are implemented, this restriction might be overridden based on permissions.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: