-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
229 adapt fertiscan to the new datastore with container #235
base: 224-enable-users-grouping-on-the-datastore
Are you sure you want to change the base?
229 adapt fertiscan to the new datastore with container #235
Conversation
0a63bea
to
c919ea0
Compare
@Francois-Werbrouck Is it possible to make both those arguments optional? |
This should be solved. The controller only takes the model which contain all the ids |
All the basic work for the Rework the Fertiscan Inspection CRUD Workflow should be done. @snakedye Testing has been done on, therefor it should better work. Side notes,
def register_analysis(): #Previously the Create of CRUD
def new_inspection()->InspectionController: #New Create of CRUD
def __init__(self, inspection_model: Inspection):
def get_inspection_image_location_data(self, cursor: Cursor)->tuple[UUID,UUID]:
def update_inspection(self, cursor: Cursor, user_id: UUID, updated_data: dict | Inspection,)->Inspection:
async def delete_inspection(self, cursor:Cursor, user_id: UUID)-> DBInspection:
|
f079d0d
to
ca9ee34
Compare
…nd-for-better-performance-and-scalability (#250) * Issue #249: Moved DB new_inspection to python module * Issue #249: Moved DB `update_inspection()` into python module * Add error handeling to Ingredients * Issue #249: Fertiscan Datastore tests passing * Issue #249: All Query tests are passing * Issue #249: Formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far. The new API is well suited for the backend.
This PR
Sub issues based on this PR (waiting to be merged):
upload_date
andupdated_at
to be included inInspection
for consistency #251)What needs review: