Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue #234: registration numbers #458

Merged
merged 14 commits into from
Feb 13, 2025
Merged

issue #234: registration numbers #458

merged 14 commits into from
Feb 13, 2025

Conversation

k-allagbe
Copy link
Member

@k-allagbe k-allagbe commented Feb 10, 2025 •
edited
Loading

Feb-10-2025 18-35-23

@k-allagbe k-allagbe linked an issue Feb 10, 2025 that may be closed by this pull request
As an inspector, I want to view and edit the registration number for each ingredient if available #234
Closed
@k-allagbe k-allagbe force-pushed the 234-registration-numbers branch from 06e300e to 4e2c302 Compare February 10, 2025 20:37
@k-allagbe k-allagbe force-pushed the 234-registration-numbers branch from 78d4b93 to 466d281 Compare February 11, 2025 00:19
@k-allagbe k-allagbe force-pushed the 234-registration-numbers branch from 466d281 to cc9a79d Compare February 11, 2025 01:18
@k-allagbe k-allagbe marked this pull request as ready for review February 11, 2025 01:36
@k-allagbe k-allagbe requested a review from a team as a code owner February 11, 2025 01:36
SamuelPelletierEvraire
SamuelPelletierEvraire requested changes Feb 11, 2025
View reviewed changes
src/components/StyledDeleteButton.tsx
size="small"
className="text-white"
data-testid="styled-delete-button"
>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add arial-label

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Added in VerifiedListRow component.

@k-allagbe k-allagbe force-pushed the 234-registration-numbers branch from cc9a79d to 9b0881f Compare February 11, 2025 20:54
@k-allagbe k-allagbe merged commit ec2223c into main Feb 13, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelPelletierEvraire SamuelPelletierEvraire Awaiting requested review from SamuelPelletierEvraire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

As an inspector, I want to view and edit the registration number for each ingredient if available
2 participants
@k-allagbe @SamuelPelletierEvraire