Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #63: build and push docker container to github registry #66

Conversation

ThomasCardin
Copy link
Member

@ThomasCardin ThomasCardin commented Jan 9, 2024

TODO

  • Tag an images on commit inside a PR (3 tags | PR number, commit number and branch name)
  • Tag an images on PR merged (2 tags | Branch name and commit number)
  • Remove the previous images when another commit is pushed to the pull request

Issue

@ThomasCardin
Copy link
Member Author

ThomasCardin commented Jan 11, 2024

Expected behavior for now
image

@ThomasCardin
Copy link
Member Author

This is the first iteration of the solution, we would like to manage git tags bases on commit and add them to the images. See #68 for more information

@rngadam
Copy link
Contributor

rngadam commented Jan 16, 2024

I see some thumbs up and comments but the fixes don't seem to be in. I suggest to switch PR that need work to switch to draft.

@rngadam
Copy link
Contributor

rngadam commented Jan 25, 2024

I see some thumbs up and comments but the fixes don't seem to be in. I suggest to switch PR that need work to switch to draft.

ping

Copy link
Contributor

@rngadam rngadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

open conversations still pending response here

@ThomasCardin
Copy link
Member Author

open conversations still pending response here

I commented on thoses that are done

@rngadam
Copy link
Contributor

rngadam commented Jan 29, 2024

I commented on thoses that are done

maybe switch to draft if it is still ongoing work?

@ThomasCardin ThomasCardin marked this pull request as draft January 30, 2024 15:12
@ThomasCardin ThomasCardin marked this pull request as ready for review January 31, 2024 02:20
@ThomasCardin
Copy link
Member Author

ThomasCardin commented Jan 31, 2024

@rngadam You can see the behavior of this workflow (including the script) in this organization that I created for testing purposes (e.g., here are the packages https://github.com/orgs/testing-tcardin/packages).

@ThomasCardin
Copy link
Member Author

@rngadam ping

@ThomasCardin ThomasCardin force-pushed the 63-as-a-devops-i-would-like-to-create-a-workflow-to-push-images-to-this-organisation-docker-registry branch from f09d550 to f5c6ce4 Compare February 6, 2024 22:47
@ThomasCardin ThomasCardin merged commit 3a739bc into main Feb 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a DevOps, I would like to create a workflow to push images to this organisation docker registry
2 participants