Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/physics_checkpointer #351

Open
wants to merge 64 commits into
base: main
Choose a base branch
from
Open

Feature/physics_checkpointer #351

wants to merge 64 commits into from
+1,368 −20

Conversation

elynnwu
Copy link
Collaborator

@elynnwu elynnwu commented Oct 4, 2022 •
edited
Loading

Purpose

This PR extends checkpointers to Physics and glue code and enables driver tests for multistep checkpoints.

Code changes:

  • Provide a list of relevant code changes and the side effects they have on other code.

Checklist

Before submitting this PR, please make sure:

  • You have followed the coding standards guidelines established at Code Review Checklist.
  • Docstrings and type hints are added to new and updated routines, as appropriate
  • All relevant documentation has been updated or added (e.g. README, CONTRIBUTING docs)
  • For each public change and fix in pace-util, HISTORY has been updated
  • Unit tests are added or updated for non-stencil code changes

elynnwu and others added 30 commits August 30, 2022 11:18
@elynnwu
fix variable mismatch
beefed4
@elynnwu
reinitialize dycore to reset temp storages
7ad0486
@elynnwu
Merge branch 'main' into fix/checkpointer-validation
e873534
@elynnwu
Merge branch 'main' into fix/checkpointer-validation
8119251
@elynnwu
fix var name
6788d77
@elynnwu
fvdynamics-out tracers in compute domain only
70c044e
@elynnwu
update data version
deef15c
@elynnwu
revert comment
2c0fbdc
@elynnwu
fix driver subset
f91c22e
@elynnwu
clean up translate test
534a887
@elynnwu
Merge branch 'main' into fix/checkpointer-validation
ab5992f
@elynnwu
add comment
9154218
@elynnwu
Merge branch 'main' into current
5842e3e
@elynnwu
Bump to 8.1.3
3a33976
@elynnwu
add physics and driver savepoint tests
cd8907b
@elynnwu
specify experiement name
36573ac
@elynnwu
add python version to caching
e0beac8
@elynnwu
separate test, increase threshold for circleci
7dbb1b9
@elynnwu
update test names
ef9a475
@elynnwu
update config
889e19f
@mcgibbon
add first attempt at unified savepoints target
04cc70a
@mcgibbon
Merge branch 'feature/add-circleci-physics-driver-test' of github.com…
52d89ad 
…:ai2cm/pace into feature/add-circleci-physics-driver-test
@mcgibbon
attempt to put most of the test logic in a command
89df5ce
@mcgibbon
fix config to validate
e36a10a
@mcgibbon
fix test_driver, lint, and dycore_savepoints_mpi
343a1c2
@mcgibbon
add remaining circleci plans
74d0e1d
@mcgibbon
activate venv correctly in driver test
1941476
@mcgibbon
use independent keys for gt caching
0ead115
@mcgibbon
downgrade serial savepoint tests to medium resource type
c6011ca
@elynnwu
add h5netcdf to requirement
3e9d080
mcgibbon and others added 25 commits September 19, 2022 23:42
@mcgibbon
Merge branch 'main' into feature/checkpointer_circleci
516f60f
@mcgibbon
run the 54rank test on an xlarge worker
c79eec4
@mcgibbon
delete duplicated test definitions
f96cb35
@mcgibbon
fix path for savepoint tests
e0e6e79
@mcgibbon
move directory to match moved path in last commit
6f88f0b
@mcgibbon
remove driver 54rank compiled test from CircleCI
4becd03
@mcgibbon
increase driver_savepoints_mpi resource type to xlarge
8589707
@mcgibbon
Merge branch 'main' into feature/checkpointer_circleci
19fbcf1
@mcgibbon
checkpointer test works with remapping and tracer advection
fcecc1a
@mcgibbon
Merge branch 'main' into feature/checkpointer_circleci
92bb68e
@elynnwu
Merge branch 'main' into feature/checkpointer_circleci
bdda2bf
@elynnwu
physics checkpointer init
5c59895
@elynnwu
update phys and driver out
5ea06df
@elynnwu
physics checkpoint working for 1 step
538d943
@elynnwu
physics checkpoint working
ddea611
@elynnwu
2 step driver threshold
19b9944
@elynnwu
Merge branch 'main' into feature/physics_checkpointer
61a24c5
@elynnwu
delete unused checkpoint
480a16a
@elynnwu
lint
90c26d9
@elynnwu
Merge branch 'feature/physics_checkpointer'
b394f02
@elynnwu
resolve circular dependency
4c85dea
@elynnwu
Merge branch 'feature/physics_checkpointer' of github.com:ai2cm/pace …
62d48b5 
…into feature/physics_checkpointer
@elynnwu
lint on the right python version
9fdd382
@elynnwu
Merge branch 'main' into feature/physics_checkpointer
3a379ba
@elynnwu
remove unchecked variable
87f5115
@elynnwu elynnwu marked this pull request as ready for review October 11, 2022 21:46
Base automatically changed from feature/checkpointer_circleci to main October 18, 2022 22:29
@FlorianDeconinck FlorianDeconinck added the blocked Blocked by another PR / feature label Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
blocked Blocked by another PR / feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elynnwu @FlorianDeconinck @mcgibbon