Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: split composition of url into two variables #5

Merged
merged 3 commits into from
Jun 11, 2024
Merged

improvement: split composition of url into two variables #5

merged 3 commits into from
Jun 11, 2024

Conversation

danielbinschmid
Copy link
Contributor

Bugfix that occured while working on mantra-benchmarks.

@danielbinschmid danielbinschmid changed the title improvement: split url in two variables to avoid line-splitting becau… improvement: split composition of url into two variables Jun 11, 2024
@Pseudomanifold
Copy link
Contributor

Consider disabling the linter here via # fmt: skip or # noqa. I think it's a valid argument to keep the URL in one (long) line.

@ErnstRoell ErnstRoell merged commit 284c0a8 into mantra-dev Jun 11, 2024
2 checks passed
@danielbinschmid danielbinschmid deleted the feat_url_handling branch June 11, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErnstRoell ErnstRoell Awaiting requested review from ErnstRoell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielbinschmid @Pseudomanifold @ErnstRoell