Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent pip install from trying to compile typed-ast under pypy3 #5496

Closed
wants to merge 2 commits into from

Conversation

webknjaz
Copy link
Member

What do these changes do?

$sbj

Are there changes in behavior for the user?

N/A

Related issue number

N/A

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@webknjaz webknjaz requested a review from asvetlov as a code owner February 25, 2021 01:18
@webknjaz webknjaz self-assigned this Feb 25, 2021
@webknjaz
Copy link
Member Author

Looks like we need to separate requirements files for pypy vs cpython.

@derlih
Copy link
Contributor

derlih commented Feb 28, 2021

@webknjaz check #5505
When the legacy pip resolver is used, everything installs fine for pypy and cpython

@webknjaz
Copy link
Member Author

We should adopt this to work with any resolver.

@greshilov greshilov mentioned this pull request Mar 1, 2021
5 tasks
@webknjaz webknjaz added the bot:chronographer:skip This PR does not need to include a change note label Oct 20, 2021
@webknjaz webknjaz enabled auto-merge (squash) October 20, 2021 12:23
@webknjaz webknjaz closed this Oct 20, 2021
auto-merge was automatically disabled October 20, 2021 13:10

Pull request was closed

@asvetlov asvetlov deleted the bugfixes/pip-tools-constraint-pypy3 branch October 28, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants