Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure empty body response for 1xx/204/304 per RFC 9112 sec 6.3 #7756

Merged
merged 65 commits into from
Nov 2, 2023
Merged

Ensure empty body response for 1xx/204/304 per RFC 9112 sec 6.3 #7756

merged 65 commits into from
Nov 2, 2023

Commits on Oct 27, 2023

  1. Remove Transfer-Encoding for empty body response per RFC 9112 sec 6.3 

    `Transfer-Encoding` and `Content-Length` will be removed
from the server response when sending a 1xx (Informational),
204 (No Content), or 304 (Not Modified) status since
no body is expected for these status codes

Older aiohttp would incorrectly send an body of "0\r\n\r\n"
when chunked was set for Transfer-Encoding. This changes
ensures aiohttp can still reforward requests from these
versions without http parser failing since the parser
would previous try to read these incorrect responses, but
no longer does
    @bdraco
    bdraco committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    62586b2 View commit details
    Browse the repository at this point in the history

  2. review

    @bdraco
    bdraco committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    dce3e25 View commit details
    Browse the repository at this point in the history

  3. make enable_chunking conditional on status_code_indicates_empty_body

    @bdraco
    bdraco committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    e3db2b8 View commit details
    Browse the repository at this point in the history

  4. Handle HEAD response as well

    @bdraco
    bdraco committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    3fb3f79 View commit details
    Browse the repository at this point in the history

  5. move asserts out of side effect (keep mock since it needs to be async)

    @bdraco
    bdraco committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    8f9f752 View commit details
    Browse the repository at this point in the history

  6. fix regression

    @bdraco
    bdraco committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    65d711f View commit details
    Browse the repository at this point in the history

  7. remove unreachable

    @bdraco
    bdraco committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    efcbcaf View commit details
    Browse the repository at this point in the history

  8. add functional tests

    @bdraco
    bdraco committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    9c8c8fa View commit details
    Browse the repository at this point in the history

  9. add a head test as well

    @bdraco
    bdraco committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    8ed3c5e View commit details
    Browse the repository at this point in the history

  10. reduce comment

    @bdraco
    bdraco committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    028e8a2 View commit details
    Browse the repository at this point in the history

  11. reduce comment

    @bdraco
    bdraco committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    9d54c05 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2023

  1. add test for empty body status

    @bdraco
    bdraco committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    d60e402 View commit details
    Browse the repository at this point in the history

  2. fixes for empty body with client

    @bdraco
    bdraco committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    ce8e12e View commit details
    Browse the repository at this point in the history

  3. must_be_empty_body

    @bdraco
    bdraco committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    591875d View commit details
    Browse the repository at this point in the history

  4. move must_be_empty_body block out one level

    @bdraco
    bdraco committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    5b557b9 View commit details
    Browse the repository at this point in the history

  5. dry

    @bdraco
    bdraco committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    ae2f8d1 View commit details
    Browse the repository at this point in the history

  6. one more place

    @bdraco
    bdraco committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    66443af View commit details
    Browse the repository at this point in the history

  7. http/1.0 does allow 0

    @bdraco
    bdraco committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    1f1b241 View commit details
    Browse the repository at this point in the history

  8. Add connect to _must_be_empty_body

    @bdraco
    bdraco committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    04e6cfa View commit details
    Browse the repository at this point in the history

  9. adjust test

    @bdraco
    bdraco committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    7975313 View commit details
    Browse the repository at this point in the history

  10. simplify mocking

    @bdraco
    bdraco committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    b8d5991 View commit details
    Browse the repository at this point in the history

  11. dry

    @bdraco
    bdraco committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    d94f959 View commit details
    Browse the repository at this point in the history

  12. fix http/1.0 keep alive with empty body

    @bdraco
    bdraco committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    66befbd View commit details
    Browse the repository at this point in the history

  13. stale debug

    @bdraco
    bdraco committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    fbd91c6 View commit details
    Browse the repository at this point in the history

  14. assert order

    @bdraco
    bdraco committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    9ef28a0 View commit details
    Browse the repository at this point in the history

  15. missed one

    @bdraco
    bdraco committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    772b33b View commit details
    Browse the repository at this point in the history

  16. typo

    @bdraco
    bdraco committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    f3853f0 View commit details
    Browse the repository at this point in the history

  17. adjust test for zero length

    @bdraco
    bdraco committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    5ff372a View commit details
    Browse the repository at this point in the history

  18. dry

    @bdraco
    bdraco committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    a71eaf2 View commit details
    Browse the repository at this point in the history

  19. refactor for rfc7230 section-3.3.2

    @bdraco
    bdraco committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    50f534f View commit details
    Browse the repository at this point in the history

  20. revert

    @bdraco
    bdraco committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    68f3d12 View commit details
    Browse the repository at this point in the history

  21. more reverts

    @bdraco
    bdraco committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    1cf5b38 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2023

  1. document

    @bdraco
    bdraco committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    45e303c View commit details
    Browse the repository at this point in the history

  2. fixes

    @bdraco
    bdraco committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    eab7c2b View commit details
    Browse the repository at this point in the history

  3. adjust test

    @bdraco
    bdraco committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    856b388 View commit details
    Browse the repository at this point in the history

  4. adjust test

    @bdraco
    bdraco committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    0080a6a View commit details
    Browse the repository at this point in the history

  5. explict test for 204/304

    @bdraco
    bdraco committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    f413083 View commit details
    Browse the repository at this point in the history

  6. explict test for 204/304

    @bdraco
    bdraco committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    233bced View commit details
    Browse the repository at this point in the history

  7. explict test for 204/304

    @bdraco
    bdraco committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    c76368f View commit details
    Browse the repository at this point in the history

  8. explict test for 204/304

    @bdraco
    bdraco committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    1329334 View commit details
    Browse the repository at this point in the history

  9. explict test for 101/204/304

    @bdraco
    bdraco committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    a2e4976 View commit details
    Browse the repository at this point in the history

  10. explict test for 1xx

    @bdraco
    bdraco committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    78c8742 View commit details
    Browse the repository at this point in the history

  11. it was still wrong since one is not always a subset of

    @bdraco
    bdraco committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    7e1712e View commit details
    Browse the repository at this point in the history

  12. fix order

    @bdraco
    bdraco committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    9d32134 View commit details
    Browse the repository at this point in the history

  13. remove comment since its moved to helper and better explained

    @bdraco
    bdraco committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    253db8a View commit details
    Browse the repository at this point in the history

  14. remove comment since its moved to helper and better explained

    @bdraco
    bdraco committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    ff7c712 View commit details
    Browse the repository at this point in the history

  15. make sure no body

    @bdraco
    bdraco committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    f9e831a View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. sync with client side pr

    @bdraco
    bdraco committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    8d47fef View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into ignore_transfer_encoding_304_rfc_9112_sq

    @bdraco
    bdraco authored Oct 30, 2023
    Configuration menu
    Copy the full SHA
    2f6cade View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into ignore_transfer_encoding_304_rfc_9112_sq

    @bdraco
    bdraco authored Oct 30, 2023
    Configuration menu
    Copy the full SHA
    90fa474 View commit details
    Browse the repository at this point in the history

  4. timeline

    @bdraco
    bdraco committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    3041a31 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Update spec links

    @Dreamsorcerer
    Dreamsorcerer authored Oct 31, 2023
    Configuration menu
    Copy the full SHA
    7a09009 View commit details
    Browse the repository at this point in the history

  2. Update aiohttp/web_response.py 

    Co-authored-by: Sam Bull <[email protected]>
    @bdraco @Dreamsorcerer
    bdraco and Dreamsorcerer authored Oct 31, 2023
    Configuration menu
    Copy the full SHA
    bea21de View commit details
    Browse the repository at this point in the history

  3. simplify check

    @bdraco
    bdraco committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    8f7c0e2 View commit details
    Browse the repository at this point in the history

  4. remove superfluous close

    @bdraco
    bdraco committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    a7dc41c View commit details
    Browse the repository at this point in the history

  5. adjust logic for empty body on 200 with connect

    @bdraco
    bdraco committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    5630ca5 View commit details
    Browse the repository at this point in the history

  6. sync and adjust test

    @bdraco
    bdraco committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    79d55e2 View commit details
    Browse the repository at this point in the history

  7. adjust CONNECT check for 2xx

    @bdraco
    bdraco committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    286a108 View commit details
    Browse the repository at this point in the history

  8. handle head with body unset

    @bdraco
    bdraco committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    e851e0a View commit details
    Browse the repository at this point in the history

  9. adjust test_head_returns_empty_body

    @bdraco
    bdraco committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    02f22fa View commit details
    Browse the repository at this point in the history

  10. fix 304 test

    @bdraco
    bdraco committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    15c9814 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'master' into ignore_transfer_encoding_304_rfc_9112_sq

    @bdraco
    bdraco authored Oct 31, 2023
    Configuration menu
    Copy the full SHA
    ae1c29a View commit details
    Browse the repository at this point in the history

  12. ruff

    @bdraco
    bdraco committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    3e5a6ee View commit details
    Browse the repository at this point in the history

  13. make it just a bit safer

    @bdraco
    bdraco committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    cccbdb3 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Update links

    @Dreamsorcerer
    Dreamsorcerer authored Nov 2, 2023
    Configuration menu
    Copy the full SHA
    8eebfe1 View commit details
    Browse the repository at this point in the history