Merge branch 'bugfixes/typing-__class_getitem__-signature'

PR #571

.codecov.yml

@@ -11,15 +11,15 @@ comment:
   require_changes: true
 
 coverage:
-  range: 99.09..100
+  range: 100..100
   status:
     project:
       default:
         target: 100%
       lib:
         paths:
         - frozenlist/
-        target: 97.79%
+        target: 100%
       tests:
         paths:
         - tests/

CHANGES/567.bugfix.rst

@@ -0,0 +1 @@
+571.bugfix.rst

CHANGES/571.bugfix.rst

@@ -0,0 +1,6 @@
+An incorrect signature of the ``__class_getitem__`` class method
+has been fixed, adding a missing ``class_item`` argument under
+Python 3.8 and older.
+
+This change also improves the code coverage of this method that
+was previously missing -- by :user:`webknjaz`.

frozenlist/__init__.py

@@ -3,7 +3,7 @@
 import types
 from collections.abc import MutableSequence
 from functools import total_ordering
-from typing import Type
+from typing import Any, Type
 
 __version__ = "1.4.2.dev0"
 
@@ -22,7 +22,10 @@ class FrozenList(MutableSequence):
     else:
 
         @classmethod
-        def __class_getitem__(cls: Type["FrozenList"]) -> Type["FrozenList"]:
+        def __class_getitem__(
+            cls: Type["FrozenList"],
+            cls_item: Any,
+        ) -> Type["FrozenList"]:
             return cls
 
     def __init__(self, items=None):

frozenlist/_frozenlist.pyx

@@ -9,7 +9,7 @@ cdef class FrozenList:
         __class_getitem__ = classmethod(types.GenericAlias)
     else:
         @classmethod
-        def __class_getitem__(cls):
+        def __class_getitem__(cls, cls_item):
             return cls
 
     cdef readonly bint frozen

tests/test_frozenlist.py

@@ -13,6 +13,9 @@ class FrozenListMixin:
 
     SKIP_METHODS = {"__abstractmethods__", "__slots__"}
 
+    def test___class_getitem__(self) -> None:
+        assert self.FrozenList[str] is not None
+
     def test_subclass(self) -> None:
         assert issubclass(self.FrozenList, MutableSequence)