-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't install frozenlist on Python 3.12 #433
Comments
frozenlist/_frozenlist.c:8088:47: error: no member named 'ob_digit' in 'struct _longobject'
const digit* digits = ((PyLongObject*)b)->ob_digit;
~~~~~~~~~~~~~~~~~~ ^ Looks like this is the cause: python/cpython#101292 / python/cpython#101291, new in 3.12.0a5. It works for 3.12.04. (See also aio-libs/aiohttp#7229, aio-libs/yarl#829 and cython/cython#5238 for similar issues.) |
In principle, building with Cython 3.0.0b1 should fix this specific issue. However, there could be incompatibilities with 3.0.0 preventing a direct upgrade, and 3.0.0b1 is not yet the final release. We could try to require 3.0.0b1 for Python 3.12 and up? And hope that Cython 3.0.0 makes it before 3.12 is final. Not a great option, TBH. |
I can confirm that when using Cython 3.0.0b1 the generated C files don't show the problem, plus everything continues to work for every other Python release. We'd have to use Cython 3.0.0b1 for all Python versions as there is just the one tgz source release. |
Note that the 3.12-dev build now fails again, 3.12.0a6 introduced more changes that Cython needs to adapt to:
This is cython/cython#5286 |
still failing with |
That version doesn't fail to compile in CI, meaning it's not the same issue. File a new one with the exact details. |
Sorry I was testing with the package in version |
@patrick91 I don't think so. It looks like there hasn't been a release that includes #436 just yet... |
It would be great to get a new release with #436, the final 3.12 beta was released yesterday: Next comes release candidate 1, and as much as possible we'd like it to be the same as 3.12.0 final, so the more testing projects can do now (including projects depending on frozenlist), the sooner we can find and fix bugs in 3.12. Thanks! |
thanks! |
This changes allows `pip install -r requirements.txt` to succeed when running in a cpython 3.12.2 virtualenv. See: * aio-libs/frozenlist#433 * aio-libs/aiohttp#7646
This changes allows `pip install -r requirements.txt` to succeed when running in a cpython 3.12.2 virtualenv. See: * aio-libs/frozenlist#433 * aio-libs/aiohttp#7646
Expected behaviour
Successful installation.
Actual behaviour
Details
Steps to reproduce
Your environment
The text was updated successfully, but these errors were encountered: