Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misleading URLs in the documentation #573

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

Jamim
Copy link
Contributor

@Jamim Jamim commented Dec 17, 2023

Hello @webknjaz,

I hope you can help to fix this.

What do these changes do?

Due to an issue with the configuration, links in the documentation currently point to yarl's repo instead of frozenslist's repo. To fix that, yarl substrings must be replaced with frozenlist.

Are there changes in behavior for the user?

Links to issues/PRs/commits will be fixed.

Related issue number

PR that introduced an issue:

Checklist

  • I think the code is well written
  • Add a new news fragment into the CHANGES folder

Copy link

codecov bot commented Dec 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bbe041d) 85.35% compared to head (2d3fdd6) 85.35%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #573   +/-   ##
=======================================
  Coverage   85.35%   85.35%           
=======================================
  Files          11       11           
  Lines         683      683           
  Branches       63       63           
=======================================
  Hits          583      583           
  Misses         61       61           
  Partials       39       39           
Flag Coverage Δ
CI-GHA 85.06% <100.00%> (ø)
MyPy 59.63% <100.00%> (ø)
OS-Linux 99.39% <ø> (ø)
OS-Windows 99.22% <ø> (ø)
OS-macOS 99.39% <ø> (ø)
Py-3.10.11 98.06% <ø> (ø)
Py-3.10.13 98.19% <ø> (ø)
Py-3.11.6 98.19% <ø> (ø)
Py-3.11.7 98.19% <ø> (ø)
Py-3.12.0 98.19% <ø> (ø)
Py-3.12.1 98.19% <ø> (ø)
Py-3.8.10 98.83% <ø> (ø)
Py-3.8.18 98.79% <ø> (ø)
Py-3.9.13 98.06% <ø> (ø)
Py-3.9.18 98.19% <ø> (ø)
Py-pypy7.3.11 97.67% <ø> (ø)
Py-pypy7.3.13 96.89% <ø> (ø)
VM-macos 99.39% <ø> (ø)
VM-ubuntu 99.39% <ø> (ø)
VM-windows 99.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGES/573.bugfix.rst Outdated Show resolved Hide resolved
CHANGES/573.bugfix.rst Outdated Show resolved Hide resolved
Due to an issue with the configuration, links in the documentation
currently point to yarl's repo instead of frozenslist's repo.
To fix that, yarl substrings must be replaced with frozenlist.
@Jamim Jamim force-pushed the fix/replace-yarl-with-frozenlist branch from 0bfe28f to 2d3fdd6 Compare December 18, 2023 22:43
@Jamim Jamim requested a review from webknjaz December 18, 2023 22:46
@webknjaz webknjaz enabled auto-merge (squash) January 6, 2024 17:37
@webknjaz webknjaz merged commit 6376fcd into aio-libs:master Jan 6, 2024
45 checks passed
@Jamim Jamim deleted the fix/replace-yarl-with-frozenlist branch January 6, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants