Skip to content

Commit

Permalink
STORM-901 worker-artifacts for logviewer
Browse files Browse the repository at this point in the history
Solve event-log issue, ui, dir, routes, listLogs

Fix supervisor test
  • Loading branch information
zhuol committed Oct 29, 2015
1 parent b6615d5 commit 2c2858e
Show file tree
Hide file tree
Showing 12 changed files with 579 additions and 286 deletions.
2 changes: 2 additions & 0 deletions conf/defaults.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ logviewer.port: 8000
logviewer.childopts: "-Xmx128m"
logviewer.cleanup.age.mins: 10080
logviewer.appender.name: "A1"
logviewer.max.sum.worker.logs.size.mb: 4096
logviewer.max.per.worker.logs.size.mb: 2048

logs.users: null

Expand Down
12 changes: 6 additions & 6 deletions log4j2/worker.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
</properties>
<appenders>
<RollingFile name="A1"
fileName="${sys:storm.log.dir}/${sys:logfile.name}"
filePattern="${sys:storm.log.dir}/${sys:logfile.name}.%i.gz">
fileName="${sys:workers.artifacts}/${sys:storm.id}/${sys:worker.port}/${sys:logfile.name}"
filePattern="${sys:workers.artifacts}/${sys:storm.id}/${sys:worker.port}/${sys:logfile.name}.%i.gz">
<PatternLayout>
<pattern>${pattern}</pattern>
</PatternLayout>
Expand All @@ -34,8 +34,8 @@
<DefaultRolloverStrategy max="9"/>
</RollingFile>
<RollingFile name="STDOUT"
fileName="${sys:storm.log.dir}/${sys:logfile.name}.out"
filePattern="${sys:storm.log.dir}/${sys:logfile.name}.out.%i.gz">
fileName="${sys:workers.artifacts}/${sys:storm.id}/${sys:worker.port}/${sys:logfile.name}.out"
filePattern="${sys:workers.artifacts}/${sys:storm.id}/${sys:worker.port}/${sys:logfile.name}.out.%i.gz">
<PatternLayout>
<pattern>${patternNoTime}</pattern>
</PatternLayout>
Expand All @@ -45,8 +45,8 @@
<DefaultRolloverStrategy max="4"/>
</RollingFile>
<RollingFile name="STDERR"
fileName="${sys:storm.log.dir}/${sys:logfile.name}.err"
filePattern="${sys:storm.log.dir}/${sys:logfile.name}.err.%i.gz">
fileName="${sys:workers.artifacts}/${sys:storm.id}/${sys:worker.port}/${sys:logfile.name}.err"
filePattern="${sys:workers.artifacts}/${sys:storm.id}/${sys:worker.port}/${sys:logfile.name}.err.%i.gz">
<PatternLayout>
<pattern>${patternNoTime}</pattern>
</PatternLayout>
Expand Down
19 changes: 19 additions & 0 deletions storm-core/src/clj/backtype/storm/config.clj
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,25 @@
(log-message "REMOVE worker-user " worker-id)
(.delete (File. (worker-user-file conf worker-id))))

(defn worker-artifacts-root
([conf]
(str (absolute-storm-local-dir conf) file-path-separator "workers-artifacts"))
([conf id]
(str (worker-artifacts-root conf) file-path-separator id))
([conf id port]
(str (worker-artifacts-root conf id) file-path-separator port)))

(defn get-log-metadata-file
([fname]
(let [[id port & _] (str/split fname (re-pattern file-path-separator))]
(get-log-metadata-file (read-storm-config) id port)))
([conf id port]
(clojure.java.io/file (str (worker-artifacts-root conf id) file-path-separator port file-path-separator) "worker.yaml")))

(defn get-worker-dir-from-root
[log-root id port]
(clojure.java.io/file (str log-root file-path-separator id file-path-separator port)))

(defn worker-root
([conf]
(str (absolute-storm-local-dir conf) file-path-separator "workers"))
Expand Down
Loading

0 comments on commit 2c2858e

Please sign in to comment.