Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #6132 from atwamahmoud/status-taints-support #35

Open
wants to merge 1 commit into
base: cluster-autoscaler-release-1.27-airbnb
Choose a base branch
from

Conversation

panicstevenson
Copy link

Adds support for startup taints and extends support for status taints

…port

Adds support for startup taints and extends support for status taints
provider := testprovider.NewTestCloudProvider(nil, func(nodeGroup string, node string) error {
if tc.failedNodeDeletion[node] {
return fmt.Errorf("SIMULATED ERROR: won't remove node")
// Set up other needed structures and options.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test file is the only difficult diff to review. Can you give me a sense of how you constructed it?

}

registry := kube_util.NewListerRegistry(nil, nil, podLister, pdbLister, dsLister, nil, nil, nil, nil)
ctx, err := NewScaleTestAutoscalingContext(opts, fakeClient, registry, provider, nil, nil)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where did provider definition go? Am I being blind?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants