Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

address issue#126 - remove default props in favor of js default params #127

Closed
wants to merge 1 commit into from
Closed

address issue#126 - remove default props in favor of js default params #127

wants to merge 1 commit into from

Conversation

ryanfiller
Copy link

A quick attempt to fix this issue.

@ljharb
Copy link
Collaborator

ljharb commented Jul 22, 2024

This would be a breaking change for someone relying on defaultProps, in react < 19. We'd also need tests.

@ryanfiller
Copy link
Author

This would be a breaking change for someone relying on defaultProps, in react < 19. We'd also need tests.

Running patch-package on these changes doesn't even fix the warnings in my branch anyways. Premature PR, I guess.

@ryanfiller ryanfiller closed this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

defaultProps is deprecated for fn components
2 participants
@ryanfiller @ljharb