Update README file - Extend explanations, fix formatting mistakes and expand examples #2938
Conversation
There was a problem hiding this comment.
Thanks for the quick feedback @ljharb
I hope we will be able to incorporate few of my changes.
|
@ljharb I am still thinking about 19.6 There are actually general ESLint rules regarding method chains formatting but for some reason all examples are about jQuery and DOM manipulation. No pure JS examples of methods chaining for arrays or some objects manipulation. May I reduce quantity of the jQuery examples (or make them less confusing due to the long chains of method calls with different indents) and add some additional examples with bad/good formatting? |
bstashchuk
force-pushed
the
update-readme
branch
from
bed075e
to
352c3db
Compare
|
Hi @ljharb , |
bstashchuk
force-pushed
the
update-readme
branch
2 times, most recently
from
352c3db
to
891cff2
Compare
Co-authored-by: Jordan Harband <[email protected]>
Co-authored-by: Jordan Harband <[email protected]>
bstashchuk
force-pushed
the
update-readme
branch
from
891cff2
to
396251f
Compare
| // bad | ||
| import { | ||
| firstVariable, | ||
| secondVariable, | ||
| thirdVariable | ||
| } from './someModule'; | ||
|
|
||
| // good | ||
| import { | ||
| firstVariable, | ||
| secondVariable, | ||
| thirdVariable, | ||
| } from './someModule'; |
There was a problem hiding this comment.
these are identical. why is one bad and the other good?
I am author of few JavaScript courses on Udemy.
While recording new JavaScript course I used AirBnb Style Guide in one of the sections and noticed few ways for improvements.