Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for IPv6 native clusters (airflow binds to ipv4 only by default) #845

Closed
wants to merge 2 commits into from

Conversation

xorl
Copy link

@xorl xorl commented Apr 17, 2024

What issues does your PR fix?

-fixes IPv6 native clusters cannot be reached on IPv4 addresses.

What does your PR do?

This PR makes the following changes...
Adds --hostname [::] to the exec airflow webserver command so that it binds to ipv6 as well as ipv4.

Checklist

For all Pull Requests

For releasing ONLY

xorl added 2 commits April 17, 2024 16:44
Fix for ipv6 native clusters.

Signed-off-by: Ryan Lewon <[email protected]>
Signed-off-by: Ryan Lewon <[email protected]>
@xorl xorl requested a review from thesuperzapper as a code owner April 17, 2024 20:48
@xorl xorl changed the title Patch 1 Patch for IPv6 native clusters (airflow binds to ipv4 only by default) Apr 18, 2024
@xorl
Copy link
Author

xorl commented Apr 19, 2024

@thesuperzapper @gsemet Any chance we can get a review for this simple change? It's mission critical for an OpenMetadata dependency to support this.

@thesuperzapper thesuperzapper added this to the airflow-8.8.1 milestone Apr 24, 2024
@thesuperzapper
Copy link
Member

@xorl thanks for raising this, but it turns out you can set this already with the AIRFLOW__WEBSERVER__WEB_SERVER_HOST config, so we don't need to expose a new value for it.

For example, you might set the following values:

airflow:
  config:
    AIRFLOW__WEBSERVER__WEB_SERVER_HOST: "[::]"

@thesuperzapper thesuperzapper removed this from the airflow-8.9.0 milestone Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants