Fix/audit fixes (#1327)

* Increased Delegate test coverage to 100% * Implemented audit fixes * Removed unused import
airswap · Sep 9, 2024 · dc22193 · dc22193
1 parent f12798f
commit dc22193
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/source/delegate/contracts/Delegate.sol b/source/delegate/contracts/Delegate.sol
@@ -4,7 +4,6 @@ pragma solidity 0.8.23;
 
 import "./interfaces/IDelegate.sol";
 import "@airswap/swap-erc20/contracts/interfaces/ISwapERC20.sol";
-import { ERC20 } from "solady/src/tokens/ERC20.sol";
 import { Ownable } from "solady/src/auth/Ownable.sol";
 import { SafeTransferLib } from "solady/src/utils/SafeTransferLib.sol";
 
@@ -129,7 +128,11 @@ contract Delegate is IDelegate, Ownable {
       _senderAmount
     );
 
-    ERC20(_senderToken).approve(address(swapERC20), _senderAmount);
+    SafeTransferLib.safeApprove(
+      _senderToken,
+      address(swapERC20),
+      _senderAmount
+    );
 
     swapERC20.swapLight(
       _nonce,

diff --git a/source/delegate/contracts/interfaces/IDelegate.sol b/source/delegate/contracts/interfaces/IDelegate.sol
@@ -21,7 +21,6 @@ interface IDelegate {
   error InvalidSignerAmount();
   error ManagerInvalid();
   error SenderInvalid();
-  error TransferFromFailed();
 
   event Authorize(address signatory, address signer);
   event DelegateSwap(uint256 nonce, address signerWallet);
@@ -64,7 +63,7 @@ interface IDelegate {
 
   function unsetRule(
     address sender,
-    address signerToken,
-    address senderToken
+    address senderToken,
+    address signerToken
   ) external;
 }