Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap param checks #1248

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Swap param checks #1248

merged 3 commits into from
Jan 10, 2024

Conversation

dmosites
Copy link
Member

@dmosites dmosites commented Jan 10, 2024 •
edited
Loading

Adds hasValidParams to Adapters and includes in Swap.check.
ERC20: requires id to be zero.
ERC721: requires amount to be zero.
ERC1155: requires amount to be nonzero.

@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Jan 10, 2024 •
edited
Loading

Swap param checks

Generated at commit: af572f28ae64d7e8be80472ebd6f6a1df2b9a74e

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 0
0
0
9
24
33
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dmosites dmosites merged commit cd50d65 into develop Jan 10, 2024
1 check passed
@dmosites dmosites deleted the swap-param-checks branch January 13, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smartcontrart smartcontrart smartcontrart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmosites @smartcontrart