Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delegate Updates #1345

Merged
merged 3 commits into from
Nov 23, 2024
Merged

Delegate Updates #1345

merged 3 commits into from
Nov 23, 2024

Conversation

smartcontrart
Copy link
Contributor

@smartcontrart smartcontrart commented Nov 22, 2024 •
edited by dmosites
Loading

  • Fixes incorrect signerAmount check
  • Changes expiry check to <= to match SwapERC20
  • Changes RuleExpired to RuleExpiredOrDoesNotExist
  • Adds test and updates other related tests

@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Nov 22, 2024 •
edited
Loading

Fixed SignerAmount check

Generated at commit: e4ef46e43b14d13a6331ee5b04b9bca24a1ae575

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
1
0
7
22
32
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dmosites dmosites changed the title Fixed SignerAmount check Delegate Updates Nov 23, 2024
@dmosites dmosites merged commit 73553b5 into develop Nov 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmosites dmosites dmosites approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smartcontrart @dmosites