Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: link to TF migration instructions for M3 to Thanos #668

Merged
merged 1 commit into from
Jan 30, 2025
Merged

update: link to TF migration instructions for M3 to Thanos #668

merged 1 commit into from
Jan 30, 2025

Conversation

staceysalamon-aiven
Copy link
Contributor

@staceysalamon-aiven staceysalamon-aiven commented Jan 27, 2025 •
edited
Loading

Describe your changes

Adds a link to the migration guide for Terraform resources and fixes one UI label in the instructions.

Checklist

  • The first paragraph of the page is on one line.
  • The other lines have a line break at 90 characters.
  • I checked the output.
  • I applied the style guide.
  • My links start with /docs/.

@staceysalamon-aiven staceysalamon-aiven added the review/awaitingRelease All reviews are completed. label Jan 27, 2025
@staceysalamon-aiven staceysalamon-aiven self-assigned this Jan 27, 2025
@staceysalamon-aiven staceysalamon-aiven marked this pull request as ready for review January 30, 2025 08:07
@staceysalamon-aiven staceysalamon-aiven requested a review from a team as a code owner January 30, 2025 08:07
@staceysalamon-aiven staceysalamon-aiven added review/TW A TW must review the PR. Comes after review/SME. and removed review/awaitingRelease All reviews are completed. labels Jan 30, 2025
harshini-rangaswamy
harshini-rangaswamy approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@harshini-rangaswamy harshini-rangaswamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@staceysalamon-aiven staceysalamon-aiven merged commit 46b85b5 into main Jan 30, 2025
5 checks passed
@staceysalamon-aiven staceysalamon-aiven deleted the staceys-doc-1294 branch January 30, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshini-rangaswamy harshini-rangaswamy harshini-rangaswamy approved these changes

Assignees

@staceysalamon-aiven staceysalamon-aiven

Labels
review/TW A TW must review the PR. Comes after review/SME.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@staceysalamon-aiven @harshini-rangaswamy