fix: use ServiceStateType

aiven · Sep 5, 2024 · 8c8a380 · 8c8a380
1 parent 81b510a
commit 8c8a380
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/controllers/generic_service_handler.go b/controllers/generic_service_handler.go
@@ -186,7 +186,7 @@ func (h *genericServiceHandler) get(ctx context.Context, avn *aiven.Client, avnG
 		return nil, nil
 	}
 
-	status.State = "RUNNING" // overrides REBALANCING
+	status.State = service.ServiceStateTypeRunning // overrides REBALANCING
 	meta.SetStatusCondition(&status.Conditions,
 		getRunningCondition(metav1.ConditionTrue, "CheckRunning", "Instance is running on Aiven side"))
 

diff --git a/tests/generic_service_handler_test.go b/tests/generic_service_handler_test.go
@@ -5,6 +5,7 @@ import (
 	"testing"
 	"time"
 
+	"github.com/aiven/go-client-codegen/handler/service"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 	apierrors "k8s.io/apimachinery/pkg/api/errors"
@@ -13,10 +14,10 @@ import (
 	"github.com/aiven/aiven-operator/api/v1alpha1"
 )
 
-const serviceRunningState = "RUNNING"
+const serviceRunningState = service.ServiceStateTypeRunning
 
 // serviceRunningStatesAiven these Aiven service states match to RUNNING state in kube
-var serviceRunningStatesAiven = []string{"RUNNING", "REBALANCING"}
+var serviceRunningStatesAiven = []service.ServiceStateType{service.ServiceStateTypeRunning, service.ServiceStateTypeRebalancing}
 
 func getCreateServiceYaml(project, pgName string) string {
 	return fmt.Sprintf(`