Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(service_intergration): empty user config to API convertion #526

Merged
merged 1 commit into from
Nov 10, 2023
Merged

fix(service_intergration): empty user config to API convertion #526

merged 1 commit into from
Nov 10, 2023

Conversation

ivan-savciuc
Copy link
Contributor

No description provided.

@mortenlj
Copy link
Contributor

mortenlj commented Nov 3, 2023

Any chance of this moving forward by the end of next week? We have some things waiting for this fix ...

@ivan-savciuc ivan-savciuc force-pushed the ivans-fix-empty-si-config branch from f259a64 to bcf6c47 Compare November 10, 2023 13:35
@ivan-savciuc ivan-savciuc marked this pull request as ready for review November 10, 2023 13:37
@ivan-savciuc ivan-savciuc requested a review from a team November 10, 2023 13:37
@ivan-savciuc ivan-savciuc force-pushed the ivans-fix-empty-si-config branch from bcf6c47 to 1a6fa4f Compare November 10, 2023 14:44
byashimov
byashimov approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@byashimov byashimov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: switch instead of Contains call will do the job too, but overall lgtm

@ivan-savciuc ivan-savciuc enabled auto-merge (squash) November 10, 2023 15:08
@Serpentiel Serpentiel force-pushed the ivans-fix-empty-si-config branch from 1a6fa4f to 72c9845 Compare November 10, 2023 15:39
@Serpentiel Serpentiel assigned Serpentiel and unassigned byashimov Nov 10, 2023
@Serpentiel Serpentiel added the bug Something isn't working label Nov 10, 2023
@ivan-savciuc ivan-savciuc merged commit f21a7c9 into main Nov 10, 2023
6 checks passed
@ivan-savciuc ivan-savciuc deleted the ivans-fix-empty-si-config branch November 10, 2023 15:42
@byashimov
Copy link
Contributor

Resolves #522

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byashimov byashimov byashimov approved these changes

Assignees

@ivan-savciuc ivan-savciuc

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ivan-savciuc @mortenlj @byashimov @Serpentiel