fix(controllers): object not committed properly

[byashimov]

This PR:

• fixes object updates lose during reconciliation
• sets error conditions on basic controller level

[tkaesserfm]

@byashimov yes, you were right! 😆

[byashimov]

@byashimov yes, you were right! 😆

Hey. You mean the RUNNING status? I'm fixing it right now. But it is a hard one.

[tkaesserfm]

@byashimov yes, but i only see the issue for KafkaACL.
We're only using kafka-related stuff though. What works is ServiceUser and KafkaTopic.

[byashimov]

@tkaesserfm it is actually there for every kind.
When this line is triggered, it changes the resource version by creating a secret. Then events are not attached to the resource.
Next time you change it, it goes through the loop, but no new secret is attached. That's how you get the last event.
Currently I'm fighting this to get all events in one run as it is expected.

[tkaesserfm]

Ah i see, i was talking "Status Conditions" so different thing but the symptom seems the same.

[byashimov]

Hey @tkaesserfm
I think, I have fixed it:

Status:
  Conditions:
    Last Transition Time:  2023-11-29T22:22:24Z
    Message:               failed to create service: 400: {"errors":[{"message":"Plan 'startup-24' for service type ServiceType.kafka is not available in cloud 'google-europe-west1'","status":400}],"message":"Plan 'startup-24' for service type ServiceType.kafka is not available in cloud 'google-europe-west1'"} - 
    Reason:                CreateOrUpdate
    Status:                Unknown
    Type:                  Error

The only thing is that I have narrowed down the list of reasons. It's good to have a verbose state machine, but unfortunately our controllers have just one CreateOrUpdate command for everything, and too many return statements.

That means that every return statement with an error has to have a "set a reason" line behind.
So I've left just CreateOrUpdate and a few more that can be guaranteed to be compatible with all controllers:

errConditionDelete         errCondition = "Delete"
errConditionPreconditions  errCondition = "Preconditions"
errConditionCreateOrUpdate errCondition = "CreateOrUpdate"

Regarding to missing events: turns out that by default (and actually recommended way) events might be dropped out when there are too much of them. So events are unreliable. Thankfully, you use conditions.

Can you confirm this works for you?

[ivan-savciuc]

LGTM