feat: add include_secrets to ServiceGet calls
#810
Merged
+228
−215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rriski
force-pushed
the
rriski-serviceGet-include-secrets-query-param
branch
from
ddd55da to
0d2cb3d
Compare
rriski
force-pushed
the
rriski-serviceGet-include-secrets-query-param
branch
2 times, most recently
from
b654304 to
d3b7859
Compare
byashimov
previously approved these changes
Sep 5, 2024
Assertions broke after updating to generated client. Example error:
2024/09/04 13:59:02 Operation "verify default/test-3le9gf7-opensearch is running" succeeded
opensearch_test.go:82:
Error Trace: /home/runner/work/aiven-operator/aiven-operator/tests/opensearch_test.go:82
Error: Not equal:
expected: int(245760)
actual : *float64((*float64)(0xc00139a848))
Test: TestOpenSearch
rriski
force-pushed
the
rriski-serviceGet-include-secrets-query-param
branch
from
9aa42d1 to
998cee8
Compare
byashimov
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request secrets in
ServiceGetcalls