Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Valkey resource #865

Merged
merged 5 commits into from
Jan 15, 2025
Merged

feat: add Valkey resource #865

merged 5 commits into from
Jan 15, 2025

Conversation

rriski
Copy link
Contributor

@rriski rriski commented Jan 13, 2025

Add support for Valkey service type. Resolves #863. Best reviewed commit-by-commit.

@rriski rriski requested a review from byashimov January 14, 2025 13:03
@rriski rriski force-pushed the rriski-add-valkey branch from c8704b9 to d9c7005 Compare January 14, 2025 13:03
@rriski
Copy link
Contributor Author

rriski commented Jan 14, 2025

tests

@rriski rriski marked this pull request as ready for review January 14, 2025 13:08
@rriski rriski requested a review from a team as a code owner January 14, 2025 13:08
docs/docs/api-reference/valkey.md Show resolved Hide resolved
Changes generated with:

```shell
./bin/operator-sdk-v1.36.0 create api --version v1alpha1 --kind Valkey --force
./bin/operator-sdk-v1.36.0 create webhook --version v1alpha1 --kind Valkey \
    --defaulting --programmatic-validation --conversion
```
Changes generated with `make generate`
Change generated with `make generate`
@rriski rriski force-pushed the rriski-add-valkey branch from d9c7005 to a7c5270 Compare January 15, 2025 06:54
@rriski rriski requested a review from byashimov January 15, 2025 06:54
@rriski rriski dismissed byashimov’s stale review January 15, 2025 07:44

Changes addressed

Mostly copy paste from Redis test. Prefixless connection info secret
assertions removed.
@rriski rriski force-pushed the rriski-add-valkey branch from a7c5270 to f418dd7 Compare January 15, 2025 08:34
@byashimov byashimov merged commit 7e1de21 into main Jan 15, 2025
49 of 50 checks passed
@byashimov byashimov deleted the rriski-add-valkey branch January 15, 2025 12:35
@rriski rriski mentioned this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Valkey
2 participants