Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(service): expose tech_emails #1476

Merged
merged 1 commit into from
Dec 21, 2023
Merged

feat(service): expose tech_emails #1476

merged 1 commit into from
Dec 21, 2023

Conversation

jeff-held-aiven
Copy link
Contributor

Allow users to set tech_emails member of service.

@jeff-held-aiven jeff-held-aiven force-pushed the jeff-held-aiven-service-tech-emails branch from 3457422 to 6eed2b7 Compare December 13, 2023 15:33
Serpentiel
Serpentiel previously requested changes Dec 14, 2023
View reviewed changes
internal/sdkprovider/service/project/project.go Outdated Show resolved Hide resolved
@jeff-held-aiven jeff-held-aiven force-pushed the jeff-held-aiven-service-tech-emails branch from 6eed2b7 to 5940a6c Compare December 18, 2023 10:04
@jeff-held-aiven jeff-held-aiven force-pushed the jeff-held-aiven-service-tech-emails branch 5 times, most recently from d0b926a to e558fc7 Compare December 20, 2023 11:09
byashimov
byashimov requested changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@byashimov byashimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes are required, otherwise lgtm

internal/schemautil/service.go Outdated Show resolved Hide resolved
internal/schemautil/service.go Show resolved Hide resolved
internal/sdkprovider/service/redis/redis_test.go Show resolved Hide resolved
@jeff-held-aiven jeff-held-aiven force-pushed the jeff-held-aiven-service-tech-emails branch from e558fc7 to 934d6d4 Compare December 21, 2023 10:35
@jeff-held-aiven jeff-held-aiven force-pushed the jeff-held-aiven-service-tech-emails branch from 934d6d4 to c89e54d Compare December 21, 2023 11:26
@jeff-held-aiven jeff-held-aiven marked this pull request as ready for review December 21, 2023 11:27
@jeff-held-aiven jeff-held-aiven requested a review from a team December 21, 2023 11:27
byashimov
byashimov previously approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@byashimov byashimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@byashimov byashimov enabled auto-merge (squash) December 21, 2023 11:29
@jeff-held-aiven
feat(service): expose tech_emails
803cdcf 
Allow users to set `tech_emails` member of service.
@jeff-held-aiven jeff-held-aiven force-pushed the jeff-held-aiven-service-tech-emails branch from c89e54d to 803cdcf Compare December 21, 2023 13:32
byashimov
byashimov approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@byashimov byashimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@byashimov byashimov enabled auto-merge (squash) December 21, 2023 13:35
@byashimov byashimov merged commit 817e97d into main Dec 21, 2023
10 checks passed
@byashimov byashimov deleted the jeff-held-aiven-service-tech-emails branch December 21, 2023 13:36
@Serpentiel Serpentiel added the enhancement New feature or request label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byashimov byashimov byashimov approved these changes

@Serpentiel Serpentiel Awaiting requested review from Serpentiel

Assignees

@byashimov byashimov

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeff-held-aiven @byashimov @Serpentiel