Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 remove unnecessary transforms from worker #58

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

thkruz
Copy link

@thkruz thkruz commented Dec 30, 2023

This migrates both workers and the frontend from satellite.js to ootk for better TypeScript support and modernization for alpha 5. As I am the main contributor to satellite.js I can tell you with certainty that it will not be supported as we reach 6 digit satellites and sgp4-xp formats. I know we had a discussion about AGPL vs MIT. You can hold off merging this until I either update the license or write you an exception to it. I am looking at ways to split the core functions from the ones I have added and will happily leave the core ones under MIT.

This migrates both workers and the frontend from satellite.js to ootk for better TypeScript support and modernization for alpha 5. As I am the main contributor to satellite.js I can tell you with certainty that it will not be supported as we reach 6 digit satellites and sgp4-xp formats. I know we had a discussion about AGPL vs MIT.  You can hold off merging this until I either update the license or write you an exception to it.  I am looking at ways to split the core functions from the ones I have added and will happily leave the core ones under MIT.
@thkruz
Copy link
Author

thkruz commented Jan 9, 2024

It is going to take me a few days, but I have all of the core orbital functions from ootk moved to a new library under MIT (ootk-core). That will give you all of the functionality of satellite.js plus the fixes I have made for alpha-5 (satellite number 100,000+) element sets and a lot of useful transforms - all under MIT. I will keep the more advanced math for initial orbit determination and other tasks common in commercial software under AGPL, but I don't imagine you ever needing any of that for this project.

I'll change the dependencies once the new library is on npm.

@ajmas
Copy link
Owner

ajmas commented Jan 9, 2024

No rush. I'm trying to balance things the best I can too.

@thkruz
Copy link
Author

thkruz commented Jan 13, 2024

Ton of updates/fixes:

  • Sun is in the correct location.
  • Earth is rotated correctly.
  • Scene is rotated have axis in correct direction.
  • Satellites are in the correct location.
  • Satellites position is update every frame using velocity.
  • Orbits are in the correct location.
  • ootk replaced with ootk-core (MIT License).
  • All ECI and LLA math offloaded to ootk-core.
  • satData and satCache arrays replaced with Satellite class arrays.
    • adds lots of built-in helper methods.
    • reduces back and forth with position worker.
    • consolidates parameters between space-track.org data and old satellite object.

I am using this project to determine what will be in ootk-core and to standardize terms like rightAscension vs raan, but I am confident you can proceed at this point (if you think it is ready). If there are any adjustments you'd like in the syntax of ootk-core just let me know, and if nothing is heard in the next few weeks I will mark it is officially version 1.

Let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants