Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use comptime instead of VTableImpl #18

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Use comptime instead of VTableImpl #18

merged 1 commit into from
Oct 28, 2024

Conversation

sdzx-1
Copy link
Contributor

@sdzx-1 sdzx-1 commented Oct 27, 2024

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Tests
[ ] Other

Description

Using comptime instead of VTableImpl can express semantics more accurately

Related issue

How Has This Been Tested?

Checklist

(For new features)

  • Feature is documented
  • Test cases added
  • Usage examples provided

(For bugfixes)

  • Test cases added

Screenshots (if appropriate):

@sdzx-1
Copy link
Contributor Author

sdzx-1 commented Oct 27, 2024

@akarpovskii

@akarpovskii akarpovskii merged commit efb5cb7 into akarpovskii:main Oct 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akarpovskii akarpovskii akarpovskii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdzx-1 @akarpovskii