Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update FLock documentation and deployment configuration #595

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vatsalkshah
Copy link

Summary

This PR includes updates to the project documentation and enhancements to the deployment configuration.

Changes

  • Documentation:

    • Updated FLock-validator and Flock-training-nodeREADME.md to reflect the removal of FLock whitelist
  • Configuration:

    • Updated deploy.yml to pull the latest llm-loss-validator

@vatsalkshah vatsalkshah changed the title chore: update documentation and deployment configuration chore: update FLock documentation and deployment configuration Oct 14, 2024
@Dimokus88
Copy link
Contributor

Hey @vatsalkshah !
Tnx for PR!

Please consider the appropriateness of using the latest tag in your image version.
Providers cache images and it may happen that an old version of your image will work under the latest tag.

@vatsalkshah
Copy link
Author

Thank you for pointing out that out. To address the issue of potentially using outdated images due to caching, I'll add the imagePullPolicy: Always to our YAML configuration. This change should ensure that the actual latest version of the image is always pulled and used. Does that solve the issue?

Given the frequency of our version updates, we make it mandatory for validators to run the latest version to ensure consistency and reliability in across validator deployments.

@Dimokus88
Copy link
Contributor

@vatsalkshah It might be worth adding a comment to SDL with a reference to check the current version of the image in your documentation. At now indicate the current version one for today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants