Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move leapwallet CSS library import to component-specific usage #281

Merged
merged 9 commits into from
Jul 29, 2024

Conversation

HoomanDigital
Copy link

Description

The import of the Leap Wallet CSS library was previously located at the top level of the component, which inadvertently affected the container class on the main console website. This container class is crucial for maintaining the layout and ensuring that the div elements do not extend beyond a specified width.

Changes Made

  • Moved the import of the Leap Wallet CSS library from the top of the component file to the component-specific context.

  • This change addresses layout issues by isolating the CSS impact to only where it is needed, preventing unintended interference with the container class and preserving the intended design constraints.

Benefits

  • Improved Layout Consistency: Ensures that the container class on the main console website functions as intended without being affected by external styles.
  • Scoped CSS: Reduces potential conflicts by importing the CSS library only in the context where it is actually used.

Screenshots

Before

image

After

image

@baktun14
Copy link
Contributor

Good find, thanks for fixing.

@baktun14 baktun14 merged commit 333e29a into akash-network:main Jul 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants