Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(deployment): e2e testing create deployment #392

Merged
merged 10 commits into from
Oct 4, 2024

Conversation

baktun14
Copy link
Contributor

@baktun14 baktun14 commented Sep 30, 2024

  • Added Leap wallet extension for integration tests
  • Added a test that deploys hello world app and closes it

You can ignore all the files under the Leap folder, which is basically all the files downloaded from the extension.

@baktun14 baktun14 changed the title Features/e2e testing create deployment feat(dx): e2e testing create deployment Sep 30, 2024
@baktun14 baktun14 force-pushed the features/e2e-testing-create-deployment branch from f9f2260 to 73ff838 Compare September 30, 2024 20:13
Copy link
Contributor

@ygrishajev ygrishajev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why so much leap files are needed there?
Can we rename utils into fixtures? I'd avoid names like utils/helpers as it's generally a white noise that would cause anyone to still inspect what's inside.

apps/deploy-web/playwright.config.ts Outdated Show resolved Hide resolved
apps/deploy-web/src/components/new-deployment/BidRow.tsx Outdated Show resolved Hide resolved
apps/deploy-web/tests/deploy-hello-world.spec.ts Outdated Show resolved Hide resolved
apps/deploy-web/tests/deploy-hello-world.spec.ts Outdated Show resolved Hide resolved
apps/deploy-web/tests/deploy-hello-world.spec.ts Outdated Show resolved Hide resolved
apps/deploy-web/tests/pages/DeployBasePage.tsx Outdated Show resolved Hide resolved
apps/deploy-web/tests/pages/DeployBasePage.tsx Outdated Show resolved Hide resolved
@baktun14
Copy link
Contributor Author

baktun14 commented Oct 1, 2024

Why so much leap files are needed there? Can we rename utils into fixtures? I'd avoid names like utils/helpers as it's generally a white noise that would cause anyone to still inspect what's inside.

It's basically the extension code that we need to run it.

@baktun14 baktun14 changed the title feat(dx): e2e testing create deployment test(deployment): e2e testing create deployment Oct 1, 2024
@baktun14 baktun14 merged commit f2effa8 into main Oct 4, 2024
5 checks passed
@baktun14 baktun14 deleted the features/e2e-testing-create-deployment branch October 4, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants