Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dx): ensure that commits with "refactor" and "perf" type cause release version change #646

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

stalniy
Copy link
Contributor

@stalniy stalniy commented Jan 16, 2025

Why

Sometimes we may have changes that from end user perspective is not a feature and not a bugfix but we still want it to be released. It may be either performance improvement or some small adjustments to prepare for bigger refactoring. In this case, the commit type should be "refactor" but the issue is that by default "refactor" commits do not trigger release (version bump and excluded from changelog). This is what happened with PR #634

That's why I suggest to include "refactor" and "perf" commits to release

What

Includes "refactor" and "perf" commits to release.

Tested locally, this is an example of this change:

Changelog:
## [2.28.3](https://github.com/akash-network/console/compare/console-web/v2.28.2...console-web/v2.28.3) (2025-01-16)

### Code Refactoring
* **template:** replaces /v1/templates with /v1/templates-list ([dcc986c](https://github.com/akash-network/console/commit/dcc986cc4718fc0a4b9463d3d780a5b70f9e6cd9)), closes [#477](https://github.com/akash-network/console/issues/477)

@stalniy stalniy requested a review from a team as a code owner January 16, 2025 02:58
@stalniy stalniy merged commit e6787fc into main Jan 16, 2025
5 checks passed
@stalniy stalniy deleted the chore/release-refactor branch January 16, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants