feat: adds certificate validation on provider proxy #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
stalniy
commented
Jan 22, 2025
| // will have certificate for every request | ||
| const didHandshake = Object.keys(serverCert).length > 0; | ||
|
|
||
| if (didHandshake && options.network && options.providerAddress) { |
There was a problem hiding this comment.
temporary ignore validation if options.network and options.providerAddress are empty because deploy-web also require adjustments, just didn't want to create massive PR
stalniy
force-pushed
the
feat/validate-certs
branch
10 times, most recently
from
e5164a5 to
f907e42
Compare
stalniy
force-pushed
the
feat/validate-certs
branch
from
f907e42 to
2f46f23
Compare
stalniy
force-pushed
the
feat/validate-certs
branch
from
2f46f23 to
1d5ae08
Compare
baktun14
reviewed
Jan 25, 2025
| @@ -16,6 +16,7 @@ const whitelist = [ | |||
| "https://console-beta.akash.network" | |||
| ]; | |||
|
|
|||
| app.disable("x-powered-by"); | |||
| body: options.body, | ||
| headers: new Headers(options.headers), | ||
| agent: httpsAgent | ||
| const queryParams = `?filter.state=valid&filter.owner=${providerAddress}&pagination.limit=${this.certificatesAmountToFetch}`; |
There was a problem hiding this comment.
One thing to note is that it's possible for addresses to have more than 100 certificates. Although very unlikely, it has happened in the past and resulted in hard to find bugs. This is how we load them in the frontend and we have the same function in the indexer as well.
Comment on lines
+16
to
+17
| { shortName: "ST", value: "Virginia" }, | ||
| { name: "localityName", value: "Blacksburg" }, |
There was a problem hiding this comment.
Where are these values taken from?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We need to validate provider self-signed certificate
What
nodemonfor easier local development@akasnetwork/netpackage for sharing blockchain configurationrefs: #170