Pass tests #45
Pass tests #45
Conversation
…eprecation warnings and errors
|
Hey @akataba. Thanks for the work on the tests! It looks there are a lot of code changes here to that are unrelated to the tests. Could you either remove these or make a new PR with just the test-related code? It would probably be good to rebase on top of main, or just make new branch from main, because I see the old environment classes (before the PR that separated the environments into different files and changed the environment class names) are referenced. |
…that is incompaptible with how we have written the code base so far
…orts when running tests
… related to tests passing
|
|
||
| return alg | ||
| def run_noisy_one_qubit_experiment(gate, n_training_iterations=1, noise_file=" "): |
There was a problem hiding this comment.
Since we already have a run function in utils.py that takes an environment variable, do you think it would be better to move run_noisy_one_qubit_experiment and run_noiseless_one_qubit_experiment to the scripts folder?
There was a problem hiding this comment.
The reason I defined these different functions was that building the configuration for the different environments is different and the observation dimensions are different.
There was a problem hiding this comment.
Two things:
- The environments are written such that you don't need to change the configuration if you don't want to; one function can handle both environments (e.g., https://github.com/akataba/rl-repo/blob/main/scripts/run_and_save_v3.py).
- If there is something about these particular configurations that makes you want to keep these functions, I think we should move them from the
apifolder to thescriptsfolder.
Closes #24