Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass tests #45
base: main
Are you sure you want to change the base?
Pass tests #45
Changes from 22 commits
7fd7c05
b7ae180
69c53ce
08cd5dc
8034a3e
850e395
e9a9cb0
b0e1398
9b02c28
5d7da26
e58267c
988b8ea
d7d8ae5
df9f219
7f5a667
df726a3
e28c8dd
b49e16e
8f25d02
de19842
0b80bd5
8371cf2
ef36ba1
cfb2baf
b2c82b9
705ec11
19ff62d
0f56bea
154af64
744938f
5824ae5
1ecfffb
c327517
a39697f
9d126bd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we already have a
run
function inutils.py
that takes an environment variable, do you think it would be better to moverun_noisy_one_qubit_experiment
andrun_noiseless_one_qubit_experiment
to thescripts
folder?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason I defined these different functions was that building the configuration for the different environments is different and the observation dimensions are different.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two things:
api
folder to thescripts
folder.