some upgrade

ake123 · Jan 16, 2024 · 3e60236 · 3e60236
1 parent e872bd7
commit 3e60236
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -19,8 +19,8 @@
     "web-vitals": "^2.1.4"
   },
   "scripts": {
-    "predeploy":"npm run build",
-    "deploy":"gh-pages-d build",
+    "predeploy": "npm run build",
+    "deploy": "gh-pages-d build",
     "start": "react-scripts start",
     "build": "react-scripts build",
     "test": "react-scripts test",

diff --git a/src/component/Product.jsx b/src/component/Product.jsx
@@ -9,13 +9,17 @@ const Product = () => {
   const [loading, setLoading] = useState(false);
 
   useEffect(() => {
+    let componentMounted = true;
     const getProduct = async () => {
       setLoading(true);
       const response = await fetch(`https://fakestoreapi.com/products/${id}`);
       setProduct(await response.json());
       setLoading(false);
     };
     getProduct();
+    return () => {
+      componentMounted = false;
+    };
   }, []);
 
   const Loading = () => {