Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable selection for commands in copy-mode #612

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Conversation

Inc0n
Copy link

@Inc0n Inc0n commented Aug 6, 2022

This commit enables C-a and C-e to be used with shift modifer to select region to start of line and end of line, if shift-select-mode is enabled.

This is done by putting "^" into interactive, for more information see, https://www.emacswiki.org/emacs/ShiftSelectMode.

Additionally, I would recommend to bind M-w (king-ring-save) to vterm-copy-mode-done also, which is the default key bind to region save, this change I haven't introduce in this commit. I use this bind all the time, and had to manually quite copy-mode using C-c C-t, instead of using return.

I mentioned the above here, since this commit is about introducing better integration between vterm and emacs.

@Inc0n
Copy link
Author

Inc0n commented Aug 7, 2022

This pull request is transfered to #614 instead.

@Inc0n Inc0n closed this Aug 7, 2022
@Sbozzolo
Copy link
Collaborator

Sbozzolo commented Aug 9, 2022

I was not aware of shift-select-mode. I don't see any reason why we shouldn't merge this PR.

@Sbozzolo Sbozzolo reopened this Aug 9, 2022
@Inc0n
Copy link
Author

Inc0n commented Aug 23, 2022

Oh yes, shift-select-mode, I missed this one out (was actually not aware of this either), so this commit would be adding support for shift-select-mode. I have edited that into my first comment.

@jixiuf jixiuf merged commit 36f6963 into akermu:master Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants