feat: add retry utility for unprocessed items in batch writes #1287
Conversation
...tion-dynamodb-integration/src/test/scala/projection/docs/scaladsl/ProjectionDocExample.scala
Outdated
Show resolved
Hide resolved
| minBackoff: Duration, | ||
| maxBackoff: Duration, | ||
| randomFactor: Double, | ||
| onRetry: Procedure3[BatchWriteItemResponse, Integer, Duration], |
There was a problem hiding this comment.
What should this callback be used for, other than logging? shall we have a convenient variant without the callback parameter and log by default in that case? Maybe that convenience should also create the exception by default, so without failOnMaxRetries parameter.
There was a problem hiding this comment.
Yeah, we probably don't need the flexible callbacks for the convenience method at all. Will build in the logging and exception.
There was a problem hiding this comment.
Updated in 70f0100. Always provide logging and the exception for the convenience batch writes. Move common parts to share across java and scala. Rename to a more general Requests.batchWriteWithRetries, if there are other request utilities that we end up providing.
|
|
||
| private[akka] val log: Logger = LoggerFactory.getLogger(getClass) | ||
|
|
||
| private[akka] def batchUnprocessedTotal(response: BatchWriteItemResponse): Int = |
There was a problem hiding this comment.
Internal api markers on the private[akka]
/**
* INTERNAL API
*/
@InternalApi
Refs #1286
Make the retry mechanism generic, and add a specific utility method for batch writes. Use this method internally.