-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameterize package name #17
Changes from 10 commits
54f23cc
f8351bb
4d57662
3df8fdd
ccdd74f
bcb54bc
bf49cf3
5c64598
644b95b
3902bb5
e8cf886
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
sbt.version=0.13.15 | ||
sbt.version=0.13.17 |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
addSbtPlugin("org.foundweekends.giter8" %% "sbt-giter8" % "0.7.2") | ||
addSbtPlugin("org.foundweekends.giter8" %% "sbt-giter8" % "0.10.0") |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
// sbt-paradox, used for documentation | ||
addSbtPlugin("com.lightbend.paradox" % "sbt-paradox" % "0.2.11") | ||
addSbtPlugin("com.lightbend.paradox" % "sbt-paradox" % "0.3.2") |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,12 +2,12 @@ name := "akka-quickstart-scala" | |
|
||
version := "1.0" | ||
|
||
scalaVersion := "2.12.2" | ||
scalaVersion := "2.12.6" | ||
|
||
lazy val akkaVersion = "2.5.12" | ||
lazy val akkaVersion = "$akka_version$" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
|
||
libraryDependencies ++= Seq( | ||
"com.typesafe.akka" %% "akka-actor" % akkaVersion, | ||
"com.typesafe.akka" %% "akka-testkit" % akkaVersion, | ||
"org.scalatest" %% "scalatest" % "3.0.1" % "test" | ||
"org.scalatest" %% "scalatest" % "3.0.5" % "test" | ||
) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
name = akka-quickstart-scala | ||
description = Akka is a toolkit and runtime for building highly concurrent, distributed, and fault tolerant event-driven apps. This simple application will get you started building Actor based systems with Scala. This app uses Akka, Scala, and ScalaTest. | ||
verbatim = *.scala | ||
akka_version=2.5.12 | ||
package=com.example |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
sbt.version=0.13.15 | ||
sbt.version=0.13.17 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
addSbtPlugin("io.spray" % "sbt-revolver" % "0.8.0") | ||
addSbtPlugin("io.spray" % "sbt-revolver" % "0.9.1") |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
//#full-example | ||
package com.lightbend.akka.sample | ||
package $package$ | ||
|
||
import akka.actor.{ Actor, ActorLogging, ActorRef, ActorSystem, Props } | ||
|
||
|
@@ -24,7 +24,7 @@ class Greeter(message: String, printerActor: ActorRef) extends Actor { | |
|
||
def receive = { | ||
case WhoToGreet(who) => | ||
greeting = s"$message, $who" | ||
greeting = message + ", " + who | ||
case Greet => | ||
//#greeter-send-message | ||
printerActor ! Greeting(greeting) | ||
|
@@ -50,7 +50,7 @@ class Printer extends Actor with ActorLogging { | |
|
||
def receive = { | ||
case Greeting(greeting) => | ||
log.info(s"Greeting received (from ${sender()}): $greeting") | ||
log.info("Greeting received (from " + sender() + "): " + greeting) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a bit of a shame, wouldn't there be some other way to get rid of the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I know we can use backslash log.info(s"Greeting received (from \${sender()}): \$greeting") but paradox didn't handle this. It will appear those escape characters at Lightbend Tech Hub. That's why I chose this way. If there is another way to handle this, please let me know. Thanks! :) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, so it's an interaction between paradox and g8: since we removed There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. (added #20 so we can revisit this later) |
||
} | ||
} | ||
//#printer-actor | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm good catch