Use OpenapiView and AsyncapiView to generate composite namespaces
#1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akrambek
reviewed
Feb 5, 2025
| return generate(binding, openapiSchemas, asyncapiSchemas); | ||
| } | ||
|
|
||
| protected abstract OpenapiAsyncapiCompositeConfig generate( |
There was a problem hiding this comment.
Perhaps it would be better methods are sorted by access level. LIke all public goes first then protected.
There was a problem hiding this comment.
Yes, we are doing that, first for methods, then for inner classes / interfaces.
akrambek
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies
openapi-asyncapicodebase for composite namespace generation.