refactor 'EnumComponent' & custom serialization

akopetsch · May 31, 2024 · 22df036 · 22df036
1 parent 01ec7b5
commit 22df036
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 18 deletions.
diff --git a/...ponents/Values/Customs/CustomComponent.cs → ...ializables/CustomSerializableComponent.cs b/...ponents/Values/Customs/CustomComponent.cs → ...ializables/CustomSerializableComponent.cs
@@ -2,23 +2,23 @@
 
 using System;
 
-namespace ByteSerialization.Components.Values.Customs
+namespace ByteSerialization.Components.Values.CustomSerializables
 {
-    public class CustomComponent : ValueComponent
+    public class CustomSerializableComponent : ValueComponent
     {
         private ICustomSerializable CustomSerializable { get; set; }
 
         public override void Serialize()
         {
             CustomSerializable = Node.Value as ICustomSerializable;
-            CustomSerializable.Serialize(this);
+            CustomSerializable.Serialize(Writer);
         }
 
         public override void Deserialize()
         {
             Node.Value = Activator.CreateInstance(Node.Type);
             CustomSerializable = Node.Value as ICustomSerializable;
-            CustomSerializable.Deserialize(this);
+            CustomSerializable.Deserialize(Reader);
         }
     }
 }
diff --git a/ByteSerialization/Components/Values/Customs/ICustomSerializable.cs b/ByteSerialization/Components/Values/Customs/ICustomSerializable.cs
diff --git a/...onents/Values/Primitives/EnumComponent.cs → ...lues/Primitives/EnumPrimitiveComponent.cs b/...onents/Values/Primitives/EnumComponent.cs → ...lues/Primitives/EnumPrimitiveComponent.cs
@@ -4,7 +4,7 @@
 
 namespace ByteSerialization.Components.Values.Primitives
 {
-    public class EnumComponent : PrimitiveComponent
+    public class EnumPrimitiveComponent : PrimitiveComponent
     {
         private Type UnderlyingType { get; set; }
 

diff --git a/ByteSerialization/Components/Values/ValueComponentFactory.cs b/ByteSerialization/Components/Values/ValueComponentFactory.cs
@@ -2,7 +2,7 @@
 
 using ByteSerialization.Components.Values.Composites.Collections;
 using ByteSerialization.Components.Values.Composites.Records;
-using ByteSerialization.Components.Values.Customs;
+using ByteSerialization.Components.Values.CustomSerializables;
 using ByteSerialization.Components.Values.CustomSerializers;
 using ByteSerialization.Components.Values.Primitives;
 using ByteSerialization.Extensions;
@@ -29,11 +29,11 @@ public Type GetComponentType(Type type)
                 if (type.IsPrimitive)
                     return typeof(PrimitiveComponent);
                 if (type.IsEnum)
-                    return typeof(EnumComponent);
+                    return typeof(EnumPrimitiveComponent);
             }
 
             if (typeof(ICustomSerializable).IsAssignableFrom(type))
-                return typeof(CustomComponent);
+                return typeof(CustomSerializableComponent);
 
             if (type.IsArray)
                 return typeof(ArrayComponent);

diff --git a/ByteSerialization/ICustomSerializable.cs b/ByteSerialization/ICustomSerializable.cs
@@ -0,0 +1,12 @@
+// SPDX-License-Identifier: MIT
+
+using ByteSerialization.IO;
+
+namespace ByteSerialization
+{
+    public interface ICustomSerializable
+    {
+        void Serialize(EndianBinaryWriter writer);
+        void Deserialize(EndianBinaryReader reader);
+    }
+}