fix: loading webclips settings in config (#625)

akosbalasko · Apr 11, 2024 · 71785c7 · 71785c7
1 parent c360437
commit 71785c7
Show file tree

Hide file tree

Showing 9 changed files with 31 additions and 61 deletions.
diff --git a/README.md b/README.md
@@ -129,7 +129,7 @@ To configure Yarle, you must create a config file. By default it looks like this
     "isZettelkastenNeeded": false,
     "useZettelIdAsFilename": false,
     "plainTextNotesOnly": false,
-    "skipWebClips": false,
+    "skipWebClips": true,
     "useHashTags": true,
     "outputFormat": "StandardMD",
     "taskOutputFormat": "StandardMD",

diff --git a/config.json b/config.json
@@ -17,7 +17,7 @@
     "encryptionPasswords": [],
     "skipUpdateTime": false,
     "skipSourceUrl": false,
-    "skipWebClips": false,
+    "skipWebClips": true,
     "skipTags": false,
     "useHashTags": true,
     "outputFormat": "ObsidianMD",

diff --git a/config.tana.json b/config.tana.json
@@ -17,7 +17,7 @@
     "encryptionPasswords": [],
     "skipUpdateTime": false,
     "skipSourceUrl": false,
-    "skipWebClips": false,
+    "skipWebClips": true,
     "skipTags": false,
     "useHashTags": false,
     "outputFormat": "Tana Internal Format",

diff --git a/package-lock.json b/package-lock.json
diff --git a/src/ui/index.html b/src/ui/index.html
@@ -219,14 +219,14 @@ <h5 class="info-text">General </h5>
 													</div>
 
 														<div class="form-group">
-															<!--<input type="checkbox" value="false" id='addWebClips'> -->
-														<label for="addWebClips" class="pure-checkbox">
+															<!--<input type="checkbox" value="false" id='skipWebClips'> -->
+														<label for="skipWebClips" class="pure-checkbox">
 														Convert webclips
 														<br><div style='font-size: 12px;'><i>(Convert webclips too)</i></div>
 														</label>
-														<select class="form-control configurationItem" name="addWebClips" id="addWebClips">
-															<option value="true">Yes</option>
-															<option value="false" selected>No</option>
+														<select class="form-control configurationItem" name="skipWebClips" id="skipWebClips">
+															<option value="false">Yes</option>
+															<option value="true" selected>No</option>
 														</select>
 													</div>
 

diff --git a/src/ui/settingsMapper.ts b/src/ui/settingsMapper.ts
@@ -30,12 +30,7 @@ export const mapSettingsToYarleOptions = (): YarleOptions => {
         isZettelkastenNeeded: store.get('isZettelkastenNeeded') as boolean,
         useZettelIdAsFilename: store.get('useZettelIdAsFilename') as boolean,
         plainTextNotesOnly: store.get('plainTextNotesOnly') as boolean,
-        skipLocation: !(store.get('addLocation') as boolean),
-        skipCreationTime: !(store.get('addCreationTime') as boolean),
-        skipUpdateTime: !(store.get('addUpdateTime') as boolean),
-        skipSourceUrl: !(store.get('addSourceUrl') as boolean),
-        skipWebClips: !(store.get('addWebClips') as boolean),
-        skipTags: !(store.get('addTags') as boolean),
+        skipWebClips: (store.get('skipWebClips') as boolean),
         useHashTags: store.get('useHashTags') as boolean,
         outputFormat: store.get('outputFormat') as OutputFormat,
         obsidianTaskTag: store.get('obsidianTaskTag') as string,