Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] [IMP] perf_product_inactive: Add passive support for product_attribute_variant_rules #7

Conversation

paradoxxxzero
Copy link
Contributor

As agreed, integration of OCA/product-attribute#1435 inside the perf_product_inactive module.

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #7 (d9dbb9b) into 14.0 (83c3da6) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             14.0       #7   +/-   ##
=======================================
  Coverage   78.20%   78.20%           
=======================================
  Files          36       36           
  Lines         156      156           
  Branches       33       33           
=======================================
  Hits          122      122           
  Misses         33       33           
  Partials        1        1           
Files Coverage Δ
perf_product_inactive/models/product_template.py 35.71% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sebastienbeau
Copy link
Member

/ocabot merge patch

@github-grap-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-7-by-sebastienbeau-bump-patch, awaiting test results.

@github-grap-bot github-grap-bot merged commit 90cccf4 into 14.0 Oct 20, 2023
5 of 6 checks passed
@github-grap-bot
Copy link
Contributor

Congratulations, your PR was merged at 229c314. Thanks a lot for contributing to akretion. ❤️

@github-grap-bot github-grap-bot deleted the 14.0-imp-perf_product_inactive-product_attribute_variant_rules-compat branch October 20, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants