Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config option to exempt specific paths from pre-render branch cleaning #212

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

krancour
Copy link
Member

Fixes #210

cc @evgeny-goldin @shelby-moore as we discussed yesterday.

@netlify
Copy link

netlify bot commented Oct 25, 2023

Deploy Preview for docs-kargo-render-akuity-io ready!

Name Link
🔨 Latest commit 77e0787
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-render-akuity-io/deploys/653985170e75e20008b6eaa9
😎 Deploy Preview https://deploy-preview-212.bookkeeper.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (a1b3303) 38.64% compared to head (77e0787) 39.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
+ Coverage   38.64%   39.53%   +0.89%     
==========================================
  Files          19       19              
  Lines        1162     1204      +42     
==========================================
+ Hits          449      476      +27     
- Misses        694      705      +11     
- Partials       19       23       +4     
Files Coverage Δ
config.go 63.96% <0.00%> (-1.78%) ⬇️
branches.go 33.54% <66.66%> (+11.40%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour force-pushed the krancour/preserved-paths branch from 72082aa to 2db9176 Compare October 25, 2023 20:22
Copy link
Contributor

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@krancour krancour merged commit 0c63b13 into akuity:main Oct 26, 2023
10 checks passed
@krancour krancour deleted the krancour/preserved-paths branch October 26, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: exempt some paths from pre-rendering commit branch cleanup
2 participants