Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invoke kargo render via cli #1015

Merged
merged 3 commits into from
Nov 4, 2023

Conversation

krancour
Copy link
Member

@krancour krancour commented Oct 23, 2023

Fixes #951

Part of #956

@krancour krancour added this to the v0.2.0 milestone Oct 23, 2023
@krancour krancour self-assigned this Oct 23, 2023
@krancour krancour requested a review from a team as a code owner October 23, 2023 21:04
@netlify
Copy link

netlify bot commented Oct 23, 2023

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 7e63f2e
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/65469e415ea7f200082eb197
😎 Deploy Preview https://deploy-preview-1015.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@krancour krancour marked this pull request as draft October 23, 2023 21:04
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0ebb7b8) 50.87% compared to head (7e63f2e) 50.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1015   +/-   ##
=======================================
  Coverage   50.87%   50.87%           
=======================================
  Files         113      113           
  Lines        7975     7974    -1     
=======================================
  Hits         4057     4057           
+ Misses       3772     3771    -1     
  Partials      146      146           
Files Coverage Δ
internal/controller/promotion/render.go 96.03% <100.00%> (+0.03%) ⬆️
internal/controller/promotion/root.go 100.00% <100.00%> (ø)
internal/controller/promotions/promotions.go 41.56% <100.00%> (-0.07%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour force-pushed the krancour/kargo-render-via-cli branch 2 times, most recently from 51b3c6f to 5be740f Compare October 26, 2023 21:03
@krancour krancour marked this pull request as ready for review October 26, 2023 21:04
Copy link
Contributor

@rbreeze rbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krancour krancour force-pushed the krancour/kargo-render-via-cli branch from 8b34395 to 7e63f2e Compare November 4, 2023 19:40
@krancour krancour merged commit 1979d48 into akuity:main Nov 4, 2023
14 checks passed
@krancour krancour deleted the krancour/kargo-render-via-cli branch November 4, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Perform branch rendering by invoking kargo-render as a CLI instead of library
2 participants