Use default action

alan-turing-institute · Oct 31, 2024 · 60158d5 · 60158d5
1 parent a19cc61
commit 60158d5
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/data_safe_haven/infrastructure/components/wrapped/nfsv3_storage_account.py b/data_safe_haven/infrastructure/components/wrapped/nfsv3_storage_account.py
@@ -34,10 +34,10 @@ def __init__(
         tags: Input[Mapping[str, Input[str]]],
     ):
         if allowed_service_tag == AzureServiceTag.INTERNET:
-            public_network_access = storage.PublicNetworkAccess.ENABLED
+            default_action = storage.DefaultAction.ALLOW,
             ip_rules = None
         else:
-            public_network_access = storage.PublicNetworkAccess.DISABLED
+            default_action = storage.DefaultAction.DENY,
             ip_rules = Output.from_input(allowed_ip_addresses).apply(
                 lambda ip_ranges: [
                     storage.IPRuleArgs(
@@ -63,15 +63,15 @@ def __init__(
             minimum_tls_version=storage.MinimumTlsVersion.TLS1_2,
             network_rule_set=storage.NetworkRuleSetArgs(
                 bypass=storage.Bypass.AZURE_SERVICES,
-                default_action=storage.DefaultAction.DENY,
+                default_action=default_action,
                 ip_rules=ip_rules,
                 virtual_network_rules=[
                     storage.VirtualNetworkRuleArgs(
                         virtual_network_resource_id=subnet_id,
                     )
                 ],
             ),
-            public_network_access=public_network_access,
+            public_network_access=storage.PublicNetworkAccess.ENABLED,
             resource_group_name=resource_group_name,
             sku=storage.SkuArgs(name=storage.SkuName.PREMIUM_ZRS),
             opts=opts,