Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributors names #2260

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Update contributors names #2260

merged 2 commits into from
Oct 25, 2024

Conversation

jemrobinson
Copy link
Member

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

n/a

⤴️ Summary

Update contributors' names

🌂 Related issues

n/a

🔬 Tests

Documentation only

@jemrobinson jemrobinson requested a review from a team as a code owner October 25, 2024 09:18
Copy link
Member

@JimMadge JimMadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked whether running all-contributors again will overwrite the names?

Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@jemrobinson
Copy link
Member Author

No - can I run it manually to check?

@JimMadge JimMadge requested a review from a team as a code owner October 25, 2024 10:35
@JimMadge
Copy link
Member

No - can I run it manually to check?

Yes, you can install the CLI npm install all-contributors-cli and run npx all-contributors generate.

Looks like it leaves the rc file but will use the updated names in the tables 👍.

@jemrobinson jemrobinson merged commit 6586af9 into develop Oct 25, 2024
11 checks passed
@jemrobinson jemrobinson deleted the update-contributors branch October 25, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants